This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($browser): remove base href domain when url begins with '//' #5606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents an incorrect appBase url from being calculated when the <base> href's domain begins with '//'.
ghost
assigned
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
This change prevents an incorrect appBase url from being calculated when the <base> href's domain begins with '//'. Closes angular#5606
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
This change prevents an incorrect appBase url from being calculated when the <base> href's domain begins with '//'. Closes angular#5606
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents an incorrect appBase url from being calculated when the
href's domain begins with '//'.Related to #5292, tangentially.
I don't know for sure if this is the correct behaviour, but it doesn't seem
totally unreasonable.
Before this change, if an app used
<base href="//my.domain.com/app">, the entire href would be treated as a path, and $location would behave incorrectly, due to appending it to the initial domain.So, that's a thing.